fix: simplify tree output defaults - #173
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts certkit tree to default to a command-focused text view (with opt-in text flag detail), and updates validation to handle duplicate-SKI renewal sets by using the store’s existing “latest NotAfter” selection.
Changes:
- Update
certkit treetext output defaults; add--flags/--inheritedfor opt-in flag detail while keeping--jsonas the detailed machine-readable output. - Change
RunValidationto useMemStore.GetCert(latest-expiring cert per SKI) instead of erroring on duplicate SKIs; update/extend tests accordingly. - Refresh docs/changelog/architecture notes to match the new
treebehavior and validation semantics.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/certstore/validate.go | Switch SKI lookup to GetCert (latest NotAfter) to avoid duplicate-SKI ambiguity errors |
| internal/certstore/validate_test.go | Update regression coverage to assert the later renewal cert is validated |
| cmd/certkit/tree.go | Add --flags/--inherited opt-ins; default text output becomes commands-only |
| cmd/certkit/readonly_commands_test.go | Include new tree flag globals in snapshot/restore to keep tests isolated |
| cmd/certkit/cli_semantics_test.go | Update tree command semantics tests for new default/opt-in behavior |
| README.md | Adjust CLI command summary to match new tree default |
| EXAMPLES.md | Document opt-in flag detail for tree text output |
| CHANGELOG.md | Record user-visible behavior change under Unreleased |
| .claude/docs/architecture.md | Update CLI architecture doc for new tree behavior |
| RALPH.md | Add entries documenting the fixed issues and rationale |
You can also share your feedback on Copilot code review. Take the survey.
danielewood
force-pushed
the
fix/post-merge-trust-anchor-followups
branch
from
March 11, 2026 18:45
6f516bc to
3eb10bf
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
certkit treedefault to a command-focused text view and add--flags/--inheritedopt-ins for text-mode flag detailtree --jsonas the detailed machine-readable surface and update docs/tests accordinglyValidation
pre-commit run --all-filesgo test ./cmd/certkit -run TestTreeCommand -count=1go test ./internal/certstore -run TestRunValidation -count=1